-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right-click->"Rename Notebook..." on "inactive" tab prompts to rename "active" notebook #4945
Comments
Thanks for the report, @rickhg12hs! The issue here is that we are intercepting the right click event for our menu, and preventing the tab from being activated. I will take a look at this one. |
Notes to self: Add a On context menu event in Application:
|
I'm pretty sure this is fixed in master. |
I don't think this is fixed. This also came up in #4500 and #4529. #4590 is an attempt to fix the problem, but I am not sure that it a general enough fix for what we need. For what it's worth, neither Firefox nor Chrome activate a tab upon right-clicking. It may be that we decide this is a confusing enough behavior that we do activate them on right-click, however. |
Does the tab/notebook actually need to be activated to rename it by right-clicking? |
Currently the |
Fixed by #4590 |
Hovering over any tab shows the details for that tab (super!). However, right-clicking and selecting "Rename Notebook..." for an "inactive" tab doesn't pop-up a rename for that notebook. The pop-up is to rename the "active" notebook.
This is counter-intuitive, and yes I renamed the wrong notebook and then noticed what happened.
The text was updated successfully, but these errors were encountered: