Right-click->"Rename Notebook..." on "inactive" tab prompts to rename "active" notebook

[rickhg12hs]

Hovering over any tab shows the details for that tab (super!). However, right-clicking and selecting "Rename Notebook..." for an "inactive" tab doesn't pop-up a rename for that notebook. The pop-up is to rename the "active" notebook.

This is counter-intuitive, and yes I renamed the wrong notebook and then noticed what happened.

[blink1073]

Thanks for the report, @rickhg12hs! The issue here is that we are intercepting the right click event for our menu, and preventing the tab from being activated. I will take a look at this one.

[blink1073]

Notes to self:

Add a tabBars iterator to our shell.

On context menu event in Application:

• If it is a tab bar, emit mousedown and mouseup events, then find the current tab and send an activate request to the owner.
• Otherwise, send mousedown and mouseup events to the target, and let the widget handle it.

[jasongrout]

I'm pretty sure this is fixed in master.

[ian-r-rose]

I don't think this is fixed. This also came up in #4500 and #4529. #4590 is an attempt to fix the problem, but I am not sure that it a general enough fix for what we need.

For what it's worth, neither Firefox nor Chrome activate a tab upon right-clicking. It may be that we decide this is a confusing enough behavior that we do activate them on right-click, however.

[rickhg12hs]

Does the tab/notebook actually need to be activated to rename it by right-clicking?

[ian-r-rose]

Currently the Rename command works on the active notebook, so it needs to be activated (unfortunately). It would be nice to be able to pass in the widget that received the right-click to the command, but that would be kind of tricky to implement with the current setup.

[blink1073]

Fixed by #4590