Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor gutter background contrast is too high #6121

Closed
AlbertHilb opened this issue Mar 21, 2019 · 2 comments · Fixed by #6153
Closed

Editor gutter background contrast is too high #6121

AlbertHilb opened this issue Mar 21, 2019 · 2 comments · Fixed by #6153
Labels
pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone

Comments

@AlbertHilb
Copy link
Contributor

AlbertHilb commented Mar 21, 2019

Especially in dark theme, the contrast of the editor gutter background seems too high to me.
Of course this is much a matter of personal taste; however in the default theme of three of the most popular editors today, VSCode, Atom and SublimeText, the gutter background has the same color of the surrounding. I suspect this reflects the preferences of the majority of the users.
So my proposal is to use the same color for the gutter background and the text background in the jupyterlab editor as well.

The editor as it appears now:

immagine

and as it would appear after the change I proposed

immagine

If you agree I can submit a PR.

Cheers

@vidartf
Copy link
Member

vidartf commented Mar 21, 2019

I'll leave the final call to the more design-oriented here, but I would agree that it should at least be as close as the color of the tab headers.

@jasongrout
Copy link
Contributor

+1 to the change you propose.

@jasongrout jasongrout added this to the 1.0 milestone Apr 3, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants