Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: URL truncation following workspace prompt #6592

Closed
consideRatio opened this issue Jun 17, 2019 · 4 comments
Closed

Regression: URL truncation following workspace prompt #6592

consideRatio opened this issue Jun 17, 2019 · 4 comments
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. Tag:Workspaces
Milestone

Comments

@consideRatio
Copy link
Member

consideRatio commented Jun 17, 2019

I'm experiencing the bug in #5214 on 0.35.6, perhaps it was solved in #5830 but a regression followed?

In short, visiting <my-notebook-server>/lab/tree/Untitled.ipynb is fine, but if a second tab is opened and I get a workspace prompt, I don't end up on <my-notebook-server>/lab/worskapces/a/tree/Untitled.ipynb but instead simply <my-notebook-server>/lab/workspaces/a.

/cc: @afshin, author of the initial fix of this issue

@saulshanabrook
Copy link
Member

I think this is fixed on master/the latest prerelease. I just tried it and it seems to open a file OK. Now we don't pop up with the workspace dialogue, we just autocreate a new one

@saulshanabrook
Copy link
Member

I will close this, feel free to reopen if it doesn't work on the last alpha release.

@consideRatio
Copy link
Member Author

Ah 🎉! Thanks @saulshanabrook !

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. Tag:Workspaces
Projects
None yet
Development

No branches or pull requests

3 participants