Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad styling on a generic tag #9170

Closed
fcollonval opened this issue Oct 16, 2020 · 4 comments · Fixed by #9222
Closed

Bad styling on a generic tag #9170

fcollonval opened this issue Oct 16, 2020 · 4 comments · Fixed by #9222
Labels
bug good first issue status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Milestone

Comments

@fcollonval
Copy link
Member

The following style can break extension (for instance I'm using checkbox from material-ui and the height: auto is actually reducing the clickable area) because it does not scope down the input to the container:

input[type='checkbox'] {
appearance: checkbox;
-webkit-appearance: checkbox;
-moz-appearance: checkbox;
height: auto;
}

I don't really know what is the best solution to fix this as it seems that there is no more checkbox involved within the extension manager. If so I'm happy to push a PR removing this style.

@fcollonval fcollonval added bug tag:CSS For general CSS related issues and pecadilloes labels Oct 16, 2020
@vidartf
Copy link
Member

vidartf commented Oct 23, 2020

I agree that it should either be scoped, or if unused, removed 👍

@vidartf
Copy link
Member

vidartf commented Oct 23, 2020

(Doing a git blame dive, I'm the original author of that block, and I cannot find any reasoning or memories for why it is unscoped, so I'm going to assume it just slipped through).

@jasongrout jasongrout added this to the 3.0 milestone Oct 23, 2020
@jasongrout
Copy link
Contributor

Yes, @fcollonval, please submit a PR, then.

@fcollonval
Copy link
Member Author

Thanks @vidartf and @jasongrout for the feedback. I push a PR #9222 to address this issue specifically that could be backported on 2.x.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug good first issue status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants