Remove input-checkbox style #9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
This was referenced Oct 24, 2020
github-actions
bot
added
Design System CSS
pkg:extensionmanager
tag:CSS
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #9170
The input checkbox was used in the legacy extension discovery package. This style slip in during the import in JupyterLab core.
Reference: https://github.com/vidartf/jupyterlab_discovery/blob/master/src/companions.tsx#L138
I push a PR to address #9170. So it will be easier to backport on 2.x instead of including it in #8804.
Code changes
Remove unused generic style rule.
User-facing changes
None
Backwards-incompatible changes
None