Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'merge cell above/below' commands with shortcuts #10076

Merged
merged 5 commits into from
Apr 18, 2021

Conversation

krassowska
Copy link
Contributor

References

Fixes #6330

Code changes

Added mergeAbove parameter in mergeCells function with default value false. When false this function will merge with a cell below, when true it will merge with a cell above.

User-facing changes

Added "Merge cell above" and "Merge cell below" commands with keyboard shortcuts proposed in #6330 (Ctrl+Backspace for cell above and Ctrl+Shift+M for cell below). The options are displayed in the main menu and context menu (not sure if it should stay here as it's getting long).
"Merge selected cells" works the same.

Merge cell below/above gif

Backwards-incompatible changes

I don't know of any.

@welcome
Copy link

welcome bot commented Apr 11, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone Apr 12, 2021
@jtpio
Copy link
Member

jtpio commented Apr 12, 2021

Thanks @krassowska! Do you mind adding a test case to cover the new mergeAbove parameter?

describe('#mergeCells', () => {

@krassowska
Copy link
Contributor Author

Thank you @jtpio. I've added two tests. All tests are passing on my computer, but some other things are now failing on GitHub and I don't understand why.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073
Copy link
Contributor

Kicking CI

@blink1073 blink1073 closed this Apr 18, 2021
@blink1073 blink1073 reopened this Apr 18, 2021
@blink1073
Copy link
Contributor

Update after #10094

Good catch!

@blink1073 blink1073 merged commit 765ee24 into jupyterlab:master Apr 18, 2021
@welcome
Copy link

welcome bot commented Apr 18, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@krassowska krassowska deleted the add_merge_cell_commands branch April 18, 2021 12:52
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of merge cell commands?
3 participants