-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'merge cell above/below' commands with shortcuts #10076
Add 'merge cell above/below' commands with shortcuts #10076
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Thanks @krassowska! Do you mind adding a test case to cover the new
|
Thank you @jtpio. I've added two tests. All tests are passing on my computer, but some other things are now failing on GitHub and I don't understand why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Kicking CI |
Good catch! |
References
Fixes #6330
Code changes
Added
mergeAbove
parameter inmergeCells
function with default valuefalse
. Whenfalse
this function will merge with a cell below, whentrue
it will merge with a cell above.User-facing changes
Added "Merge cell above" and "Merge cell below" commands with keyboard shortcuts proposed in #6330 (Ctrl+Backspace for cell above and Ctrl+Shift+M for cell below). The options are displayed in the main menu and context menu (not sure if it should stay here as it's getting long).
"Merge selected cells" works the same.
Backwards-incompatible changes
I don't know of any.