Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert name file feature #10609

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Revert name file feature #10609

merged 3 commits into from
Jul 12, 2021

Conversation

jess-x
Copy link
Contributor

@jess-x jess-x commented Jul 12, 2021

References

Reverts #10043 as there has not been a stable solution
per discussion #10594 (comment)

Code changes

User-facing changes

  • Name file feature is removed

Backwards-incompatible changes

  • Removed the renamed attribute from public API

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this feature! Sorry we had to bump it to next release

@blink1073
Copy link
Contributor

Ah, it looks like there are 2 images that need to be updated for the visual regression tests

@jess-x
Copy link
Contributor Author

jess-x commented Jul 12, 2021

Oh I see, I think it's the image of opened-menu needed to be updated. I am not sure how to change that

@blink1073
Copy link
Contributor

You can replace the existing images with the ones in the screenshots directory you get when you download and open the ui-test-output.zip file.

@jess-x
Copy link
Contributor Author

jess-x commented Jul 12, 2021

@blink1073, I just replaced the images, sorry that took longer because I forgot to clean up the schema

@blink1073
Copy link
Contributor

Failure is related to in-progress beta release, let's proceed so we can get #9488 finished

@blink1073 blink1073 merged commit b454016 into jupyterlab:master Jul 12, 2021
@jess-x
Copy link
Contributor Author

jess-x commented Jul 12, 2021

Thank you for the patience :)

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:docmanager pkg:docregistry pkg:services status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants