-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert name file feature #10609
Revert name file feature #10609
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this feature! Sorry we had to bump it to next release
Ah, it looks like there are 2 images that need to be updated for the visual regression tests |
Oh I see, I think it's the image of opened-menu needed to be updated. I am not sure how to change that |
You can replace the existing images with the ones in the |
@blink1073, I just replaced the images, sorry that took longer because I forgot to clean up the schema |
Failure is related to in-progress beta release, let's proceed so we can get #9488 finished |
Thank you for the patience :) |
References
Reverts #10043 as there has not been a stable solution
per discussion #10594 (comment)
Code changes
User-facing changes
Backwards-incompatible changes
renamed
attribute from public API