Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appName in page title when restoring workspaces (vs 3.1.x) #10724

Merged
merged 1 commit into from Jul 29, 2021
Merged

Use appName in page title when restoring workspaces (vs 3.1.x) #10724

merged 1 commit into from Jul 29, 2021

Conversation

bollwyvl
Copy link
Contributor

References

Code changes

  • uses PageConfig's appName instead of hard-coded JupyterLab

User-facing changes

  • Users of customized lab applications will see their custom app name after the page restarts

Backwards-incompatible changes

  • n/a

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

bollwyvl added a commit to bollwyvl/jupyterlab that referenced this pull request Jul 28, 2021
@bollwyvl
forward port of jupyterlab#10724
8778432
@bollwyvl
Copy link
Contributor Author

Seeing releaser fail... will go ahead an make another PR against master... not sure what the plan is for getting things into 3.1.1...

@bollwyvl bollwyvl mentioned this pull request Jul 28, 2021
Merged
@bollwyvl bollwyvl changed the title Use appName in page title when restoring workspaces Use appName in page title when restoring workspaces (vs 3.1.x) Jul 28, 2021
@blink1073 blink1073 added the bug label Jul 28, 2021
@blink1073 blink1073 added this to the 3.1.x milestone Jul 28, 2021
@blink1073
Copy link
Member

Seeing releaser fail... will go ahead an make another PR against master... not sure what the plan is for getting things into 3.1.1...

We can cut a 3.1.1 before fixing the check_release workflow if we need to

blink1073
blink1073 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I kicked the canceled workflows

@blink1073 blink1073 merged commit 4e81acc into jupyterlab:3.1.x Jul 29, 2021
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jul 29, 2021 via email

@bollwyvl bollwyvl mentioned this pull request Jul 30, 2021
Closed
fcollonval pushed a commit that referenced this pull request Aug 5, 2021
@bollwyvl
forward port of #10724 (#10725)
dffbe88
@SarunasAzna
Copy link

It still looks like an unresolved issue to me 🤔

If I get it correctly this suppose to keep a modified name after you build jupyterlab with a different name: jupyter lab build --name='Different Name'. As far as I tested name of the browser tab is reverted to JupyterLab a few seconds after the page is loaded and you cannot see your custom name again 😢 . This is still a problem on Jupyterlab 3.1.6, and it was ok on 3.0.16.

Or is there some other way to provide this appName configuration to the lab server?

@SarunasAzna
Copy link

This is version 3.1.6
jlab name

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@bollwyvl bollwyvl

Labels
bug pkg:apputils status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bollwyvl @blink1073 @SarunasAzna