Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use appName in page title when restoring workspaces (vs master) #10725

Merged
merged 1 commit into from Aug 5, 2021
Merged

Use appName in page title when restoring workspaces (vs master) #10725

merged 1 commit into from Aug 5, 2021

Conversation

bollwyvl
Copy link
Contributor

References

Code changes

  • uses PageConfig's appName instead of hard-coded JupyterLab

User-facing changes

  • Users of customized lab applications will see their custom app name after the page restarts

Backwards-incompatible changes

  • n/a

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl changed the title forward port of #10724 Use appName in page title when restoring workspaces (vs master) Jul 28, 2021
@blink1073 blink1073 added this to the 4.0 milestone Jul 28, 2021
@blink1073 blink1073 added the bug label Jul 28, 2021
blink1073
blink1073 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcollonval fcollonval merged commit dffbe88 into jupyterlab:master Aug 5, 2021
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 5, 2021

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@blink1073
Copy link
Member

@bollwyvl had already made a separate PR against 3.1.x

@fcollonval
Copy link
Member

@bollwyvl had already made a separate PR against 3.1.x

Sorry I missed it.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@bollwyvl bollwyvl

Labels
bug pkg:apputils status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Custom appName reverts to JupyterLab
3 participants
@bollwyvl @fcollonval @blink1073