Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up notebook test utils #11021

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

fcollonval
Copy link
Member

References

Follow up to #5000

Code changes

Export a notebook widget factory helper and mock context creator in NBTestUtils and fully use the utils in testutils from the notebook tests to ensure full capability for other extensions.

User-facing changes

Improved testing utilities for extension authors.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 marked this pull request as draft September 7, 2021 18:11
@blink1073 blink1073 added this to the 3.2.x milestone Sep 7, 2021
@blink1073 blink1073 marked this pull request as ready for review September 8, 2021 08:03
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit f3a305f into jupyterlab:master Sep 8, 2021
@blink1073 blink1073 mentioned this pull request Sep 23, 2021
@blink1073
Copy link
Contributor

@meeseeksdev please backport to 3.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 23, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 f3a305fdbbdc36734f952915ded00dbc4b14fae7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #11021: Clean up notebook test utils'
  1. Push to a named branch :
git push YOURFORK 3.2.x:auto-backport-of-pr-11021-on-3.2.x
  1. Create a PR against branch 3.2.x, I would have named this PR:

"Backport PR #11021 on branch 3.2.x (Clean up notebook test utils)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@fcollonval fcollonval deleted the fix/clean-nb-test-utils branch September 23, 2021 11:11
blink1073 pushed a commit to blink1073/jupyterlab that referenced this pull request Sep 23, 2021
blink1073 pushed a commit that referenced this pull request Sep 23, 2021
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants