Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up bumpversion #11056

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Clean up bumpversion #11056

merged 1 commit into from
Sep 10, 2021

Conversation

blink1073
Copy link
Contributor

References

Progress toward #10340

Code changes

Add "next" convenience bumpversion target

User-facing changes

None

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 3.1.x milestone Sep 10, 2021
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Test file large_code_notebook large_md_notebook
open
chromium
actual 4600 <- [5489 - 5711 - 5871] -> 13382 2780 <- [2866 - 2918 - 2942] -> 3190
expected 6938 <- [7584 - 7618 - 7760] -> 8204 3461 <- [3524 - 3534 - 3590] -> 4136
switch-from
chromium
actual 362 <- [369 - 378 - 399] -> 833 245 <- [260 - 264 - 275] -> 280
expected 464 <- [480 - 489 - 499] -> 789 310 <- [338 - 344 - 352] -> 370
switch-to
chromium
actual 1373 <- [1403 - 1498 - 1550] -> 1722 1306 <- [1327 - 1344 - 1353] -> 1409
expected 1706 <- [1730 - 1764 - 1814] -> 2015 1541 <- [1549 - 1562 - 1574] -> 1608
close
chromium
actual 4121 <- [10094 - 10619 - 11331] -> 14936 2534 <- [2720 - 2880 - 2987] -> 3339
expected 5176 <- [5770 - 10533 - 14493] -> 18824 3325 <- [3691 - 3890 - 3939] -> 4073

❗ Test metadata have changed

--- /dev/fd/63	2021-09-10 11:14:43.201303467 +0000
+++ /dev/fd/62	2021-09-10 11:14:43.201303467 +0000
@@ -8,7 +8,7 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8272CL",
+      "brand": "Xeon® Platinum 8171M",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
@@ -28,13 +28,13 @@
       "speed": 2.6,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "7",
+      "stepping": "4",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7291699200
+      "total": 7291695104
     },
     "osInfo": {
       "arch": "x64",
@@ -46,7 +46,7 @@
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
+      "serial": "0f5fd491ff264b5f9d56e03599b4fae0",
       "servicepack": "",
       "uefi": false
     }

@blink1073 blink1073 merged commit b89064d into jupyterlab:master Sep 10, 2021
@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to 3.1.x

@blink1073 blink1073 deleted the add-next-spec branch September 10, 2021 12:56
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Sep 10, 2021
blink1073 pushed a commit that referenced this pull request Sep 10, 2021
Co-authored-by: Steven Silvester <ssilvester@apple.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant