Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce labels on PRs #11496

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Enforce labels on PRs #11496

merged 1 commit into from
Nov 18, 2021

Conversation

blink1073
Copy link
Contributor

References

Use the new action from maintainer-tools.

Code changes

Adds a workflow to ensure PRs are labeled with a triage label.

User-facing changes

None

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 3.2.x milestone Nov 18, 2021
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Contributor Author

I verified that the build fails when there is no label and passes when there is a label.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks a lot @blink1073

Approving as the new job is green and the others are not relevant here.

@blink1073 blink1073 merged commit 18b2c93 into jupyterlab:master Nov 18, 2021
@blink1073 blink1073 deleted the enforce-labels branch November 18, 2021 16:26
@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to 3.2.x

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 6316 <- [7079 - 7303 - 7886] -> 8817 3215 <- [3461 - 3687 - 4074] -> 4752
expected 6250 <- [7369 - 7570 - 7947] -> 9095 3177 <- [3447 - 3661 - 3889] -> 4652
Mean relative change -2.4% ± 2.0% 1.7% ± 2.7%
switch-from
chromium
actual 792 <- [888 - 969 - 1146] -> 1508 520 <- [606 - 751 - 810] -> 1022
expected 813 <- [927 - 988 - 1199] -> 1666 510 <- [581 - 714 - 824] -> 973
Mean relative change -2.9% ± 4.4% 1.8% ± 5.2%
switch-to
chromium
actual 843 <- [888 - 939 - 989] -> 1132 633 <- [749 - 784 - 832] -> 939
expected 864 <- [922 - 975 - 1021] -> 1284 630 <- [727 - 780 - 838] -> 943
Mean relative change -3.9% ± 1.9% 1.0% ± 2.4%
close
chromium
actual 873 <- [969 - 1081 - 1372] -> 1572 584 <- [639 - 676 - 719] -> 835
expected 859 <- [992 - 1068 - 1419] -> 1625 579 <- [641 - 668 - 707] -> 884
Mean relative change -0.8% ± 5.2% 1.1% ± 2.3%

Changes are computed with expected as reference.

blink1073 added a commit that referenced this pull request Nov 18, 2021
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants