Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Frontend Typings #11537

Merged
merged 7 commits into from
Dec 7, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 24, 2021

References

This is a continuation of #11196.

Code changes

User-facing changes

None

Backwards-incompatible changes

Consumers relying on the concrete ServiceManager have to be updated.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Publish

 - @jupyterlab/builder@4.0.0-alpha.0
 - @jupyterlab/buildutils@4.0.0-alpha.0
 - @jupyterlab/template@4.0.0-alpha.0
 - @jupyterlab/application-top@4.0.0-alpha.0
 - @jupyterlab/example-app@4.0.0-alpha.0
 - @jupyterlab/example-cell@4.0.0-alpha.0
 - @jupyterlab/example-console@4.0.0-alpha.0
 - @jupyterlab/example-federated@3.0.0-alpha.0
 - @jupyterlab/example-filebrowser@4.0.0-alpha.0
 - @jupyterlab/example-notebook@4.0.0-alpha.0
 - @jupyterlab/example-terminal@4.0.0-alpha.0
 - @jupyterlab/example-federated-core@3.0.0-alpha.0
 - @jupyterlab/example-federated-md@3.0.0-alpha.0
 - @jupyterlab/example-federated-middle@3.0.0-alpha.0
 - @jupyterlab/example-federated-phosphor@3.0.0-alpha.0
 - @jupyterlab/galata@5.0.0-alpha.0
 - @jupyterlab/mock-extension@4.0.0-alpha.0
 - @jupyterlab/mock-consumer@4.0.0-alpha.0
 - @jupyterlab/mock-provider@4.0.0-alpha.0
 - @jupyterlab/mock-token@4.0.0-alpha.0
 - @jupyterlab/application-extension@4.0.0-alpha.0
 - @jupyterlab/application@4.0.0-alpha.0
 - @jupyterlab/apputils-extension@4.0.0-alpha.0
 - @jupyterlab/apputils@4.0.0-alpha.0
 - @jupyterlab/attachments@4.0.0-alpha.0
 - @jupyterlab/cells@4.0.0-alpha.0
 - @jupyterlab/celltags-extension@4.0.0-alpha.0
 - @jupyterlab/celltags@4.0.0-alpha.0
 - @jupyterlab/codeeditor@4.0.0-alpha.0
 - @jupyterlab/codemirror-extension@4.0.0-alpha.0
 - @jupyterlab/codemirror@4.0.0-alpha.0
 - @jupyterlab/completer-extension@4.0.0-alpha.0
 - @jupyterlab/completer@4.0.0-alpha.0
 - @jupyterlab/console-extension@4.0.0-alpha.0
 - @jupyterlab/console@4.0.0-alpha.0
 - @jupyterlab/coreutils@6.0.0-alpha.0
 - @jupyterlab/csvviewer-extension@4.0.0-alpha.0
 - @jupyterlab/csvviewer@4.0.0-alpha.0
 - @jupyterlab/debugger-extension@4.0.0-alpha.0
 - @jupyterlab/debugger@4.0.0-alpha.0
 - @jupyterlab/docmanager-extension@4.0.0-alpha.0
 - @jupyterlab/docmanager@4.0.0-alpha.0
 - @jupyterlab/docprovider-extension@4.0.0-alpha.0
 - @jupyterlab/docprovider@4.0.0-alpha.0
 - @jupyterlab/docregistry@4.0.0-alpha.0
 - @jupyterlab/documentsearch-extension@4.0.0-alpha.0
 - @jupyterlab/documentsearch@4.0.0-alpha.0
 - @jupyterlab/extensionmanager-extension@4.0.0-alpha.0
 - @jupyterlab/extensionmanager@4.0.0-alpha.0
 - @jupyterlab/filebrowser-extension@4.0.0-alpha.0
 - @jupyterlab/filebrowser@4.0.0-alpha.0
 - @jupyterlab/fileeditor-extension@4.0.0-alpha.0
 - @jupyterlab/fileeditor@4.0.0-alpha.0
 - @jupyterlab/help-extension@4.0.0-alpha.0
 - @jupyterlab/htmlviewer-extension@4.0.0-alpha.0
 - @jupyterlab/htmlviewer@4.0.0-alpha.0
 - @jupyterlab/hub-extension@4.0.0-alpha.0
 - @jupyterlab/imageviewer-extension@4.0.0-alpha.0
 - @jupyterlab/imageviewer@4.0.0-alpha.0
 - @jupyterlab/inspector-extension@4.0.0-alpha.0
 - @jupyterlab/inspector@4.0.0-alpha.0
 - @jupyterlab/javascript-extension@4.0.0-alpha.0
 - @jupyterlab/json-extension@4.0.0-alpha.0
 - @jupyterlab/launcher-extension@4.0.0-alpha.0
 - @jupyterlab/launcher@4.0.0-alpha.0
 - @jupyterlab/logconsole-extension@4.0.0-alpha.0
 - @jupyterlab/logconsole@4.0.0-alpha.0
 - @jupyterlab/mainmenu-extension@4.0.0-alpha.0
 - @jupyterlab/mainmenu@4.0.0-alpha.0
 - @jupyterlab/markdownviewer-extension@4.0.0-alpha.0
 - @jupyterlab/markdownviewer@4.0.0-alpha.0
 - @jupyterlab/mathjax2-extension@4.0.0-alpha.0
 - @jupyterlab/mathjax2@4.0.0-alpha.0
 - @jupyterlab/metapackage@4.0.0-alpha.0
 - @jupyterlab/nbconvert-css@4.0.0-alpha.0
 - @jupyterlab/nbformat@4.0.0-alpha.0
 - @jupyterlab/notebook-extension@4.0.0-alpha.0
 - @jupyterlab/notebook@4.0.0-alpha.0
 - @jupyterlab/observables@5.0.0-alpha.0
 - @jupyterlab/outputarea@4.0.0-alpha.0
 - @jupyterlab/pdf-extension@4.0.0-alpha.0
 - @jupyterlab/property-inspector@4.0.0-alpha.0
 - @jupyterlab/rendermime-extension@4.0.0-alpha.0
 - @jupyterlab/rendermime-interfaces@4.0.0-alpha.0
 - @jupyterlab/rendermime@4.0.0-alpha.0
 - @jupyterlab/running-extension@4.0.0-alpha.0
 - @jupyterlab/running@4.0.0-alpha.0
 - @jupyterlab/services@7.0.0-alpha.0
 - @jupyterlab/settingeditor-extension@4.0.0-alpha.0
 - @jupyterlab/settingeditor@4.0.0-alpha.0
 - @jupyterlab/settingregistry@4.0.0-alpha.0
 - @jupyterlab/shared-models@4.0.0-alpha.0
 - @jupyterlab/shortcuts-extension@4.0.0-alpha.0
 - @jupyterlab/statedb@4.0.0-alpha.0
 - @jupyterlab/statusbar-extension@4.0.0-alpha.0
 - @jupyterlab/statusbar@4.0.0-alpha.0
 - @jupyterlab/terminal-extension@4.0.0-alpha.0
 - @jupyterlab/terminal@4.0.0-alpha.0
 - @jupyterlab/theme-dark-extension@4.0.0-alpha.0
 - @jupyterlab/theme-light-extension@4.0.0-alpha.0
 - @jupyterlab/toc-extension@6.0.0-alpha.0
 - @jupyterlab/toc@6.0.0-alpha.0
 - @jupyterlab/tooltip-extension@4.0.0-alpha.0
 - @jupyterlab/tooltip@4.0.0-alpha.0
 - @jupyterlab/translation-extension@4.0.0-alpha.0
 - @jupyterlab/translation@4.0.0-alpha.0
 - @jupyterlab/ui-components-extension@4.0.0-alpha.0
 - @jupyterlab/ui-components@4.0.0-alpha.0
 - @jupyterlab/vdom-extension@4.0.0-alpha.0
 - @jupyterlab/vdom@4.0.0-alpha.0
 - @jupyterlab/vega5-extension@4.0.0-alpha.0
 - @jupyterlab/example-services-browser@4.0.0-alpha.0
 - node-example@4.0.0-alpha.0
 - @jupyterlab/example-services-outputarea@4.0.0-alpha.0
 - @jupyterlab/testutils@4.0.0-alpha.0

Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
@jtpio
Copy link
Member Author

jtpio commented Dec 6, 2021

Some tests are failing due to the major version bump, since the packages have not been published to npm yet.

@jtpio
Copy link
Member Author

jtpio commented Dec 6, 2021

For reference this seems to be working fine on Binder:

image

Also the major version bump does not prevent the prebuilt jupyterlab-link-share extension defined here to be activated:

- jupyterlab-link-share=0.2

Although webpack logs some warnings in the dev tools console:

image

@jtpio
Copy link
Member Author

jtpio commented Dec 6, 2021

The failing CI checks will require a new 4.0 alpha release to be done as a follow-up. Which I'm happy to do after the PR is merged.

This will also help other PRs that introduce breaking changes to avoid merge conflicts on many packages, since the version bump is done here in one go. And closes #11600.

cc @blink1073 if you would like to have a quick look, since this is a continuation of the original PR started in #11196, now rebased onto the latest master.

@jtpio jtpio marked this pull request as ready for review December 6, 2021 18:04
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @jtpio, looks good to me!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

The mean relative comparison is computed with 95% confidence.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 4227 <- [4320 - 4365 - 4414] -> 4707 2870 <- [2943 - 2960 - 2981] -> 3098
expected 4190 <- [4309 - 4374 - 5252] -> 6147 2752 <- [2858 - 2927 - 3104] -> 3395
Mean relative change -6.7% ± 2.1% -0.7% ± 1.1%
switch-from
chromium
actual 535 <- [599 - 623 - 714] -> 1029 441 <- [458 - 469 - 481] -> 610
expected 551 <- [607 - 640 - 741] -> 1104 428 <- [462 - 491 - 564] -> 619
Mean relative change -3.9% ± 4.0% -7.5% ± 2.1%
switch-to
chromium
actual 592 <- [641 - 656 - 674] -> 808 489 <- [512 - 528 - 537] -> 562
expected 698 <- [723 - 736 - 750] -> 862 545 <- [627 - 637 - 647] -> 673
Mean relative change -10.7% ± 1.4% -16.5% ± 1.0%
close
chromium
actual 533 <- [560 - 590 - 947] -> 997 433 <- [445 - 451 - 462] -> 493
expected 626 <- [676 - 694 - 756] -> 1084 474 <- [507 - 520 - 553] -> 647
Mean relative change -5.1% ± 6.0% -16.0% ± 1.5%

Changes are computed with expected as reference.

❗ Test metadata have changed
--- /dev/fd/63	2021-12-06 23:06:30.251544709 +0000
+++ /dev/fd/62	2021-12-06 23:06:30.251544709 +0000
@@ -4,7 +4,7 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "98.0.4695.0"
+    "chromium": "97.0.4666.0"
   },
   "systemInformation": {
     "cpu": {

@jtpio
Copy link
Member Author

jtpio commented Dec 7, 2021

Thanks @blink1073!

Moving forward with this and making a new alpha release right after.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.