Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark snapshots as part of galata snapshots #12413

Merged
merged 8 commits into from
Apr 20, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Apr 15, 2022

References

Currently the benchmark snapshots are not updated when requesting update galata snapshots

Code changes

This update the benchmark snapshots too
Bump @playwright/test
Make document tests more robust by moving the right sidebar panel handle (as done for the left sidebar)

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval
Copy link
Member Author

please update snapshots

@fcollonval fcollonval marked this pull request as ready for review April 15, 2022 09:23
@fcollonval fcollonval marked this pull request as draft April 15, 2022 12:45
@fcollonval
Copy link
Member Author

Font in the terminal has changed apparently...

@fcollonval
Copy link
Member Author

please update snapshots

@fcollonval fcollonval marked this pull request as ready for review April 19, 2022 16:58
@fcollonval fcollonval merged commit e2950b5 into jupyterlab:master Apr 20, 2022
@fcollonval fcollonval deleted the fix/update-bench-snapshots branch April 20, 2022 06:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant