-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder of webpackConfig merge #13040
Reorder of webpackConfig merge #13040
Conversation
This changes the webpackConfig merge order to allow it to pre-empt the rule for .html files. Closes jupyterlab#13032.
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @matthewturk
I have a suggestion to fix the linter error otherwise this is looking good.
You can add co-authors to a commit in GitHub with a special expression in the commit description: see documentation. But I'm find not being a co-author.
|
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@fcollonval Thank you for the linter help! I thought I had correctly set it up in vscode, but ... looks like I hadn't. :) |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @matthewturk
@meeseeksdev please backport to 3.4.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Co-authored-by: Matthew Turk <matthewturk@gmail.com>
The merge order of the different webpack config items currently pre-empts any
.html
-catching rules.References
.vue.html
files #13032Code changes
This changes the webpackConfig merge order to allow it to pre-empt the rule for
.html files. Putting the
.html
rule after the inclusion ofwebpackConfig
allows extension developers to override that rule, which is helpful for
situations such as VueJS extensions that use
vue-loader
. Previously,vue-loader
was testing if.vue.html
would be caught by it. The order ofconfig merging prevented the
.vue.html
from being executed. This changeshouldn't affect any situations where
.html
was not being specified in thewebpackConfig
override.Closes #13032.
User-facing changes
This should not have any user-facing changes, and any developer-facing changes
should only arise in the case that a
webpackConfig
rule was specified andnot caught by the overridden configuration, which would arguably not be
intended behavior anyway.
Backwards-incompatible changes
There should be no changes.