Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve core_path before calling nodejs #13126

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

fcollonval
Copy link
Member

References

Fixes #13125

Code changes

Resolve core_path before calling nodejs subprocess

User-facing changes

Consistent resolution of relative path to cwd for jupyter labextension build

Backwards-incompatible changes

No

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added the bug label Sep 26, 2022
@fcollonval fcollonval added this to the 3.4.x milestone Sep 26, 2022
@fcollonval fcollonval merged commit 040d7fe into jupyterlab:master Sep 26, 2022
@fcollonval fcollonval deleted the fix/13125-ci-usage branch September 26, 2022 13:26
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 26, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 040d7fec4114c3737ec454b3bedeed6b01af370e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #13126: Resolve core_path before calling nodejs'
  1. Push to a named branch:
git push YOURFORK 3.4.x:auto-backport-of-pr-13126-on-3.4.x
  1. Create a PR against branch 3.4.x, I would have named this PR:

"Backport PR #13126 on branch 3.4.x (Resolve core_path before calling nodejs)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Linux usage is broken
1 participant