Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key name for nbformat minor version #13377

Merged

Conversation

fcollonval
Copy link
Member

References

Fix #13376

Code changes

Set first the metadata before the content when loading a notebook from a JSON file.

User-facing changes

Preserve the cell id

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.6.x milestone Nov 4, 2022
@fcollonval fcollonval added the bug label Nov 4, 2022
@fcollonval fcollonval modified the milestones: 3.6.x, 3.6.0 Nov 4, 2022
@fcollonval fcollonval force-pushed the fix/13376-CI-failure-on-36x-branch branch from 81d54a0 to fb3880a Compare November 4, 2022 11:04
@fcollonval fcollonval marked this pull request as ready for review November 4, 2022 11:05
@fcollonval fcollonval changed the title Set first the metadata before loading the notebook content Fix key name for nbformat minor version Nov 4, 2022
@fcollonval fcollonval merged commit c7fb1de into jupyterlab:3.6.x Nov 4, 2022
@fcollonval fcollonval deleted the fix/13376-CI-failure-on-36x-branch branch November 4, 2022 14:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant