Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands without shortcuts #14015

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fcollonval
Copy link
Member

References

Fix #13705

as of now, it does not work as expected because a selector cannot be defined in the UI.

Code changes

Add the commands without shortcuts defined

User-facing changes

Can add a shortcut on commands without it

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@JasonWeill
Copy link
Contributor

@fcollonval We discussed this at the frontends meeting. Because the underlying code has been refactored since you opened this PR, would you like to close this PR or update the code to match the new structure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic commands are missing in shortcut editor
4 participants