-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude .yarn cache from the dist #14242
Conversation
Thanks for making a pull request to jupyterlab! |
I wanted to also exclude tests but it seems that jupyterlab.browser_checks uses this module, so my PR now only removes the I can confirm that the wheel is now 9.2Mb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference.
Waiting for localhost:8888 Cell memory leaksCreate a code cellMemory change: +155 kB Leak detected: YesLeaking objects:
Leaking collections: Create a markdown cellMemory change: -148 kB Leak detected: NoLeaking objects:
Leaking collections: Create a raw cellMemory change: +141 kB Leak detected: YesLeaking objects:
Leaking collections:
File editor memory leaksCreate a fileMemory change: -73.6 kB Leak detected: NoLeaking objects:
Notebook memory leaksCreate a notebookMemory change: +25.9 kB Leak detected: YesLeaking objects:
2 passing (6m)
|
References
Fixes #14241
The last release of JupyterLab is 90Mb! https://pypi.org/project/jupyterlab/4.0.0a37/#files
This PR fixes it by removing the
.yarn
cache from the sdist and the wheelKudos to @trungleduc for spotting it