Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter ydoc #14374

Merged
merged 1 commit into from Apr 17, 2023
Merged

Update jupyter ydoc #14374

merged 1 commit into from Apr 17, 2023

Conversation

hbcarlos
Copy link
Member

Fixes the metadata bug described in #13930 (comment)

References

Code changes

Updated jupyter ydoc. The bug was fixed in jupyter-server/jupyter_ydoc#158

User-facing changes

Backwards-incompatible changes

@hbcarlos hbcarlos added the bug label Apr 12, 2023
@hbcarlos hbcarlos self-assigned this Apr 12, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

I reran the example CI job to see if it was flaky (like the other failures).

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples are failing before - so let's merge this one.

@fcollonval fcollonval merged commit 32d92ef into jupyterlab:3.6.x Apr 17, 2023
76 of 141 checks passed
@hbcarlos hbcarlos deleted the fix_metadata branch April 17, 2023 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants