added dynamic functionality to the text spacing

[j264415]

References

#9684 Adjustable Text Spacing (Low priority)

Fixes #12999

Code changes

Changed height in CSS of Launcher file on the: LauncherCard, LauncherCard-label and LauncherCard-label p to "min-height" to allow for text spacing to be dynamic.

User-facing changes

When the issue on #9684 is reproduced, the code changes allow for the full text within the Launcher cards to fully be shown no matter the text spacing or font, as the launcher card will automatically adjust to the text format.

To test changes, inspect page and go to where the launcher card titles are written and add extra text with spacing within the class="jp-LauncherCard-label" <p>...</p> tag.

Backwards-incompatible changes

None

[jupyterlab-probot]

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[j264415]

@manfromjupyter Please review changes.

[krassowski]

I tested it locally it looks good!

Sorry, about an earlier comment that I since deleted - it was meant to go here #14560 (comment). I will force-push to remove the last commit which is not relevant here.

[krassowski]

Thank you @j264415. This PR also fixes #12999 (I updated the description to link them).

My understanding is that while this addresses the accessibility issues when user manually overrides text spacing, #9684 could be further addressed by exposing a user-configurable spacing (hence we should not close #9684 yet).

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️