Build cleanup #1477
Merged
Build cleanup #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidartf
reviewed
Jan 11, 2017
| # scripts that are called at very beginning, before repo cloning | ||
| init: | ||
| - ps: (new-object net.webclient).DownloadFile('https://github.com/git-for-windows/git/releases/download/v2.11.0.windows.1/Git-2.11.0-64-bit.exe', 'C:\\git-setup.exe') | ||
| - cmd: START /WAIT C:\\git-setup.exe /VERYSILENT |
There was a problem hiding this comment.
Unless you have a specific need for a newer version of git you can remove this bit :)
vidartf
reviewed
Jan 11, 2017
| # scripts to run before tests | ||
| before_test: | ||
| - git config --global user.email appveyor@fake.com | ||
| - git config --global user.name "AppVeyor CI" |
There was a problem hiding this comment.
This is also only relevant if you call out to git during your tests.
|
Thanks @vidartf, I removed the appveyor file altogether because I couldn't figure out how to get appveyor enabled for this org. |
|
Figured it out. |
|
Ugh, no I didn't... There is a granularity of permissions problem. |
|
Found it! |
afshin
approved these changes
Jan 11, 2017
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models our python build after
nbdimeand adds basic install check onappveyor.