New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit changed signal from output area when an output is updated #14785
Conversation
Thanks for making a pull request to jupyterlab! |
well that was clearly wrong... |
Some subtle elements, as the fixture I pushed a fix to also use the Hopefully the CI will be green(er 😉) |
Thanks for the alley-oop 🏀, there's clearly more about galata i don't know
than otherwise.
Likely this pattern of "check what ends up on disk after doing stuff" could
be applied in other places.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bollwyvl
|
@meeseeksdev please backport to 4.0.x |
…en an output is updated
…ut is updated (#14835) Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com>
References
Code changes
changed
fromOutputAreaModel
when an output is updated withsetData
(or changes in any other way, presumably)User-facing changes
setData
Backwards-incompatible changes