Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add global keyboard shortcuts for all sidebar widgets #14799

Merged
merged 61 commits into from
Dec 14, 2023
Merged

Add global keyboard shortcuts for all sidebar widgets #14799

merged 61 commits into from
Dec 14, 2023

Conversation

g547315
Copy link
Contributor

@g547315 g547315 commented Jul 7, 2023 •
edited
Loading

References

The intended functionality here is to have a keyboard shortcuts for every widget on the tab bar that can be used from anywhere in the application to toggle it open and close

Code changes

  • Added a new commands with the functionality to activate, close and shift tab focus on to the chosen element on tab-bar

  • Exposed this command in the command palette

User-facing changes

New commands to activate:

  • Left sidebar widgets with alt + number
  • Right sidebar widgets with alt + shift + number

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@welcome
Copy link

welcome bot commented Jul 7, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@g547315 g547315 force-pushed the Keyboard-navigation-right-sidebar branch from 414de9e to 4d8923e Compare July 7, 2023 14:35
@g547315
Copy link
Contributor Author

g547315 commented Jul 7, 2023

Please review @gabalafou

@g547315
Copy link
Contributor Author

g547315 commented Jul 10, 2023

please update galata snapshots

@g547315
Copy link
Contributor Author

g547315 commented Jul 10, 2023

please update documentation snapshots

@github-actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions
Copy link
Contributor

Galata snapshots updated.

@g547315
Copy link
Contributor Author

g547315 commented Jul 31, 2023

please update documentation snapshots
please update galata snapshots

@github-actions
Copy link
Contributor

Documentation snapshots updated.

@github-actions
Copy link
Contributor

Galata snapshots updated.

@g547315 g547315 requested a review from krassowski August 1, 2023 09:50
@g547315 g547315 force-pushed the Keyboard-navigation-right-sidebar branch from ac90b43 to e5d35f2 Compare November 30, 2023 17:17
@g547315
Copy link
Contributor Author

g547315 commented Dec 1, 2023

please update galata snapshots

@g547315
Copy link
Contributor Author

g547315 commented Dec 1, 2023

please update documentation snapshots

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Documentation snapshots updated.

@g547315 g547315 closed this Dec 1, 2023
@g547315 g547315 reopened this Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Galata snapshots updated.

@g547315 g547315 force-pushed the Keyboard-navigation-right-sidebar branch 2 times, most recently from 280f3bb to 3d26985 Compare December 1, 2023 14:04
@g547315
Copy link
Contributor Author

g547315 commented Dec 1, 2023

@gabalafou
@krassowski

Can this PR be merged?, The failing test are not due to the code changes make

@g547315 g547315 mentioned this pull request Dec 7, 2023
Merged
2 tasks
@brichet
Copy link
Contributor

brichet commented Dec 12, 2023

@krassowski what do you think about merging this PR.
The failing tests are not related.

@g547315 @brichet
Update galata/test/documentation/commands.test.ts-snapshots/commandsL…
778e7d7 
…ist-documentation-linux.json

Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
@brichet brichet merged commit 0a49be6 into jupyterlab:main Dec 14, 2023
79 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 14, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@krassowski krassowski changed the title Add global keyboard shortcuts for all tab bar widgets Add global keyboard shortcuts for all sidebar widgets Dec 20, 2023
This was referenced Feb 6, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krassowski krassowski krassowski left review comments

@brichet brichet brichet approved these changes

Assignees

@g547315 g547315

Labels
enhancement pkg:application tag:Accessibility tag:Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@g547315 @krassowski @gabalafou @brichet