Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page option copyAbsolutePath enabling to copy absolute path #14842

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Add page option copyAbsolutePath enabling to copy absolute path #14842

merged 4 commits into from
Jul 31, 2023

Conversation

pauky
Copy link
Contributor

@pauky pauky commented Jul 18, 2023 •
edited
Loading

References

Fixes #9485
Relates jupyterlab_server jupyterlab/jupyterlab_server#405

Code changes

add page option for copy absolute path, which can replace copy path that is relative.

User-facing changes

None

Backwards-incompatible changes

Obtain absolute paths instead of relative paths when copying paths in filebrowser.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@pauky pauky mentioned this pull request Jul 18, 2023
Merged
@pauky pauky changed the title feat(filebrowser): add page option for copyAbsolutePath, which can re… feature(filebrowser): add page option for copyAbsolutePath, which can re… Jul 18, 2023
@pauky pauky changed the title feature(filebrowser): add page option for copyAbsolutePath, which can re… feature: add page option for copyAbsolutePath, which can re… Jul 18, 2023
@pauky pauky changed the title feature: add page option for copyAbsolutePath, which can re… enhancement: add page option for copyAbsolutePath, which can re… Jul 18, 2023
@pauky pauky mentioned this pull request Jul 18, 2023
Closed
fcollonval
fcollonval approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pauky

Did you get the chance to test it locally?

@fcollonval fcollonval added this to the 4.1.0 milestone Jul 19, 2023
@fcollonval
Copy link
Member

fcollonval commented Jul 19, 2023 •
edited
Loading

CI failures are not related

@krassowski krassowski changed the title enhancement: add page option for copyAbsolutePath, which can re… Add page option copyAbsolutePath enabling to copy absolute path Jul 19, 2023
@fcollonval
Copy link
Member

@pauky would you mind adding a note in the documentation about the new configuration for this at:

https://github.com/jupyterlab/jupyterlab/blob/main/docs/source/user/files.rst#L99

@pauky
Copy link
Contributor Author

pauky commented Jul 26, 2023

@pauky would you mind adding a note in the documentation about the new configuration for this at:

https://github.com/jupyterlab/jupyterlab/blob/main/docs/source/user/files.rst#L99

Doc updated, please review it.

@fcollonval
Copy link
Member

Thanks a lot @pauky for the patience.

remaining CI failures are not related.

@fcollonval fcollonval merged commit 308fae3 into jupyterlab:main Jul 31, 2023
75 of 77 checks passed
@welcome
Copy link

welcome bot commented Jul 31, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@pauky pauky mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@pauky pauky

Labels
documentation enhancement pkg:filebrowser
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Make Copy Path more useful
2 participants
@pauky @fcollonval