Copy absolute path with first slash in the file browser #15168
Conversation
|
Thanks for making a pull request to jupyterlab! |
| @@ -65,6 +65,7 @@ import { | |||
| import { find, map } from '@lumino/algorithm'; | |||
| import { CommandRegistry } from '@lumino/commands'; | |||
| import { ContextMenu } from '@lumino/widgets'; | |||
| import { posix } from 'path'; | |||
There was a problem hiding this comment.
This will not work as the code is running in the browser, not in a Node runtime.
There was a problem hiding this comment.
Function PathExt.join was wrapped by it, and it can be execed in browser.
There was a problem hiding this comment.
No, it cannot be used in browser because browsers do not implement Node runtime. You would need to add a dependency on path-browserify, which is what the @jupyterlab/coreutils package which implements PathExt.join does:
However, ideally this implementation detail and dependency would not be propagated to filebrowser-extension, and either a new argument would be added to one of PathExt methods, or a new method created altogether and used in here.
krassowski
changed the title
References
Follow-up of #14842
There is no first slash when coping a absolute path.
Code changes
Change
PathExt.jsontoposix.json.User-facing changes
None.
Backwards-incompatible changes
None.
Edit to specify how it relates to 14842