-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In defer mode render enough cells to fill the viewport #14865
In defer mode render enough cells to fill the viewport #14865
Conversation
even if it takes more than a macro cycle
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bot please run benchmark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@meeseeksdev please backport to 4.0.x |
…ll the viewport
…wport (#14905) Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
even if it takes more than a macro cycle
References
Fixes #14608
Code changes
In notebook defer rendering mode, cells are rendered to at least fill the viewport before starting rendering on idle time.
User-facing changes
Cells should not pop-up when opening a notebook
Notebook opening time may increase
Backwards-incompatible changes
None