-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration tests #14886
Fix integration tests #14886
Conversation
Thanks for making a pull request to jupyterlab! |
bot please update documentation snapshots |
Documentation snapshots updated. |
ac88f8e
to
e350fc1
Compare
Otherwise the changes look good, thanks for looking into it 👍 The UI tests have been failing regularly for a couple of weeks now. Is there a way to bring the check back to green in this PR? |
I'll rebase because I hope that #14865 will fix the benchmark test in the UI Tests job |
e350fc1
to
a3a67fe
Compare
bot please update galata snapshots |
Galata snapshots updated. |
All green ✔️ 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to 4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
References
Fixes #14885
Code changes
None
User-facing changes
None
Backwards-incompatible changes
None