Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests #14886

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Conversation

fcollonval
Copy link
Member

References

Fixes #14885

Code changes

None

Update snapshots

User-facing changes

None

Backwards-incompatible changes

None

@fcollonval fcollonval linked an issue Jul 31, 2023 that may be closed by this pull request
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval
Copy link
Member Author

bot please update documentation snapshots

@fcollonval fcollonval added this to the 4.0.x milestone Jul 31, 2023
@github-actions
Copy link
Contributor

Documentation snapshots updated.

@fcollonval fcollonval marked this pull request as ready for review July 31, 2023 14:48
@fcollonval fcollonval closed this Jul 31, 2023
@fcollonval fcollonval reopened this Jul 31, 2023
@fcollonval fcollonval force-pushed the 14885-ui-tests-for-extension-manager-is-broken branch from ac88f8e to e350fc1 Compare August 2, 2023 14:45
@jtpio
Copy link
Member

jtpio commented Aug 2, 2023

Ah the logo actually doesn't render really well on the snapshots and in the extension manager:

image

image

So maybe we could upload a better one for the organization first?

@jtpio
Copy link
Member

jtpio commented Aug 2, 2023

Otherwise the changes look good, thanks for looking into it 👍

The UI tests have been failing regularly for a couple of weeks now. Is there a way to bring the check back to green in this PR?

@fcollonval
Copy link
Member Author

The UI tests have been failing regularly for a couple of weeks now. Is there a way to bring the check back to green in this PR?

I'll rebase because I hope that #14865 will fix the benchmark test in the UI Tests job

@fcollonval fcollonval force-pushed the 14885-ui-tests-for-extension-manager-is-broken branch from e350fc1 to a3a67fe Compare August 2, 2023 16:50
@fcollonval
Copy link
Member Author

bot please update galata snapshots

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Galata snapshots updated.

@fcollonval fcollonval closed this Aug 3, 2023
@fcollonval fcollonval reopened this Aug 3, 2023
@jtpio
Copy link
Member

jtpio commented Aug 3, 2023

All green ✔️ 🎉

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 6988200 into main Aug 3, 2023
77 of 79 checks passed
@jtpio jtpio deleted the 14885-ui-tests-for-extension-manager-is-broken branch August 3, 2023 11:40
@jtpio
Copy link
Member

jtpio commented Aug 3, 2023

@meeseeksdev please backport to 4.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 3, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6988200dac80b5aeb7dd4647cff5de02482170a9
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #14886: Fix integration tests'
  1. Push to a named branch:
git push YOURFORK 4.0.x:auto-backport-of-pr-14886-on-4.0.x
  1. Create a PR against branch 4.0.x, I would have named this PR:

"Backport PR #14886 on branch 4.0.x (Fix integration tests)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI tests for extension manager is broken
2 participants