-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MathJax font override, avoid double initialization #15230
Conversation
Thanks for making a pull request to jupyterlab! |
); | ||
|
||
class EmptyFont extends TeXFont { | ||
protected static defaultFonts = {} as any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the actual important thing
Presumably the example test passed: certainly not seeing the issue locally any longer. Not sure what the story is on the other UI tests. |
Nice, thanks! I switched the label from Also this can likely be backported to |
/js\/output\/chtml\/fonts\/tex-woff-v2\/MathJax_(Zero|Math-Italic|Main-Regular)\.woff$/ | ||
) === null | ||
) { | ||
if (msg.type() === 'error') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah these ignored error were suggesting something was not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to 4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
I'll take a look at the manual backport when i get a chance. |
References
Code changes
TeXFont.defaultFonts
staticprotected _ensureInitialized
to aPrivate
namespacePromiseDelegate
to avoid race initilization conditions404
ignoresfont-display: swap
to reduce FLOUCUser-facing changes
.woff
fonts should no longer be downloaded twice from the default URL ({window.location}/js/output/chtml/
)typeset
should not be able to enter the async init code twiceBackwards-incompatible changes