Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to marked 9.0.3, mermaidjs 10.5.0, update binder config #15214

Merged
merged 8 commits into from
Oct 6, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 3, 2023

References

Code changes

  • bump to mermaid 10.5.0 for security fix
  • bump to marked 9.0.3... just because
  • update binder deps
    • notebook 7 from conda-forge
    • jupyter-collaboration 1.2.0 from pip
      • deps from conda-forge
      • package itself can't be from conda-forge, due to hard-coded jupyterlab-link-share, which can't be removed without punishing loss of environment.yml cache layer

    • silence all cache-related activities from yarn
      • this generates {number of deps} * {4+/-1} messages which one can't do anything about

      • makes binder and CI logs enormous, unreadable, and hide real information

      • as "cute" node CLI IO is notoriously slow (especially on windows), calculating and printing these probably slows down the install noticeably, TBD

  • ???

User-facing changes

  • ???

Backwards-incompatible changes

  • n/a

Future Work

  • Mermaid Usage Instructions Missing #15139 seems like a "markdown cheat sheet"
    • should appear
      • not only in the docs
      • and not only of mermaid
    • document (and defend with sources) all deviations from the original perl script
      • GFM, $ Math, etc.
    • would make a great test
    • unless we decide to make markdown extensible wouldn't need to be extensible

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl changed the title update to mermaidjs 10.5.0 Update to mermaidjs 10.5.0, update binder config Oct 3, 2023
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Oct 3, 2023

Difference in binder log size:

  10916  111126 1943973 new-binder.txt
  16742  272502 2993052 old-binder.txt

@bollwyvl bollwyvl changed the title Update to mermaidjs 10.5.0, update binder config Update to marked 9.0.3, mermaidjs 10.5.0, update binder config Oct 3, 2023
@bollwyvl bollwyvl marked this pull request as ready for review October 3, 2023 16:50
Comment on lines -151 to -152
// santizing is applied by the sanitizer
sanitize: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity that option has been removed in Marked 8.0.0: markedjs/marked#2936

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bollwyvl

@fcollonval fcollonval added this to the 4.1.0 milestone Oct 4, 2023
@jtpio jtpio merged commit 2ce7eb2 into jupyterlab:main Oct 6, 2023
75 of 77 checks passed
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Oct 6, 2023

❤️

@bollwyvl bollwyvl deleted the bump-mermaid-1050 branch October 6, 2023 13:27
bollwyvl added a commit to bollwyvl/jupyterlab that referenced this pull request Oct 6, 2023
krassowski pushed a commit that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants