Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jupyter-ui-toolkit #15600

Merged

Conversation

fcollonval
Copy link
Member

References

Fixes #15456

Code changes

Upgrade jupyter-ui-toolkit to 0.14.0 that drops the dependency on @microsoft/fast-components

It can be seen that @microsoft/fast-components has been removed from the yarn.lock file.

User-facing changes

Improve toolbar button styling when disabled (part of the fixes in 0.14.0).

Backwards-incompatible changes

N/A

@fcollonval fcollonval added the bug label Jan 3, 2024
@fcollonval fcollonval added this to the 4.1.0 milestone Jan 3, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member

The visual regression tests seem to indicate some kind of a focus handling change (regression?).

@fcollonval
Copy link
Member Author

I'm releasing jupyter-ui-toolkit with a fix for this: jupyterlab-contrib/jupyter-ui-toolkit#88

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fcollonval!

@krassowski krassowski merged commit 266d009 into jupyterlab:main Jan 25, 2024
86 of 151 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fast stack to non-deprecated packages
2 participants