Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dotted outline from active code cell #16070

Merged
merged 5 commits into from Mar 29, 2024

Conversation

JasonWeill
Copy link
Contributor

References

Fixes #15965.

User-facing changes

Before this change, active and focused code cells had a one-pixel dark outline:

dotted-line

This change suppresses this outline:

image

Backwards-incompatible changes

None.

@JasonWeill JasonWeill added bug tag:CSS For general CSS related issues and pecadilloes labels Mar 29, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member

Wow, this change even got caught on visual tests:

Actual Expected
image image

@krassowski
Copy link
Member

krassowski commented Mar 29, 2024

Huh, the examples snapshot needs updating too, but its not clear how to get the updated one.

Edit: Well, the link to assets was at the end of the test 🤦

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JasonWeill!

Let's merge once the CI is green.

@krassowski krassowski merged commit 74eeb13 into jupyterlab:main Mar 29, 2024
81 checks passed
@krassowski krassowski added this to the 4.1.x milestone Mar 29, 2024
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Mar 29, 2024
krassowski pushed a commit that referenced this pull request Mar 29, 2024
)

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One-pixel dotted line in active code cell
2 participants