Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear output area when empty #16208

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

NexVeridian
Copy link
Contributor

References

closes #14299

Code changes

Clear output area when empty in Callback on output changes, see this

User-facing changes

For before see #14299

After:

2024-04-19.19-01-26.mp4

Backwards-incompatible changes

None

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link

welcome bot commented Apr 20, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski added this to the 4.1.x milestone Apr 20, 2024
packages/cells/src/widget.ts Outdated Show resolved Hide resolved
packages/cells/src/widget.ts Outdated Show resolved Hide resolved
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NexVeridian!

@krassowski krassowski merged commit ab7e1a1 into jupyterlab:main Apr 21, 2024
81 checks passed
Copy link

welcome bot commented Apr 21, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

JasonWeill pushed a commit to JasonWeill/jupyterlab that referenced this pull request Apr 22, 2024
* Clear output area when empty

* Save last cell output height

* Moving some variables for clearing cell output

* Check if height is defined/not defined before changing it

---------

Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
@NexVeridian NexVeridian deleted the Clear-output-area-when-empty branch April 24, 2024 20:17
gderocher pushed a commit to gderocher/jupyterlab that referenced this pull request Apr 26, 2024
* Clear output area when empty

* Save last cell output height

* Moving some variables for clearing cell output

* Check if height is defined/not defined before changing it

---------

Co-authored-by: krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty output area is not cleared
2 participants