Dynamic label for toggle sidebar element in keyboard shortcuts #16218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
reviewed
Apr 21, 2024
There was a problem hiding this comment.
Thanks for starting this! Two suggestions:
- the call to
trans.__needs a slight adjustment as arguments do not get translated - the existing label should be kept as a fallback when args are not given because a command label can be also queried without arguments.
krassowski
reviewed
Apr 21, 2024
krassowski
changed the title
JasonWeill
pushed a commit
to JasonWeill/jupyterlab
that referenced
this pull request
Apr 22, 2024
…erlab#16218) * Dynamic label for toggle sidebar element in ketboard shortcuts * Adapted review comments. * Adapting review comments.
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
…erlab#16218) * Dynamic label for toggle sidebar element in ketboard shortcuts * Adapted review comments. * Adapting review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #16217