Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize the use of ellipses in command and menu items #16237

Merged
merged 16 commits into from
Apr 26, 2024
Merged

Harmonize the use of ellipses in command and menu items #16237

merged 16 commits into from
Apr 26, 2024

Commits on Apr 24, 2024

  1. Update browser.json 

    Adjusted wording to satisfy issue jupyterlab#16321

Use "Folder", not "Directory", in file browser settings jupyterlab#16231
    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a305b31 View commit details
    Browse the repository at this point in the history

  2. -Removed elipses from: 

     File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025
    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2a125a7 View commit details
    Browse the repository at this point in the history

  3. -Removed elipses from: 

     File>Save and Export Notebook As

-Added elipses to:
 File>Close and Shut Down Notebook
 Help>Show Keyboard Shortcuts

 There remain some dual nature menu items that may or may not pop up a prompt depending on save history of current open files. I did not change these elipse situations Examples: File > Save and File > Close All Tabs

IAW standards mentioned in issue jupyterlab#16025
    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7074846 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/Rob-P-Smith/jupyterlab

    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    fdf4593 View commit details
    Browse the repository at this point in the history

  5. Delete Untitled.ipynb

    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7455639 View commit details
    Browse the repository at this point in the history

  6. Delete Untitled1.ipynb

    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8ab5c04 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'jupyterlab:main' into elipses

    @Rob-P-Smith
    Rob-P-Smith committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    0bea50e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    10165a8 View commit details
    Browse the repository at this point in the history

  2. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1fad340 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Corrections Applied per JasonWeill's feedback.

    @Rob-P-Smith
    Rob-P-Smith committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9222a07 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    110c2f4 View commit details
    Browse the repository at this point in the history

  3. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a91123e View commit details
    Browse the repository at this point in the history

  4. Update Playwright Snapshots

    @github-actions
    github-actions[bot] committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    64814ee View commit details
    Browse the repository at this point in the history

  5. Revert unrelated changes

    @krassowski
    krassowski committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    5053709 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into elipses

    @krassowski
    krassowski committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4edca34 View commit details
    Browse the repository at this point in the history

  7. Fix test

    @krassowski
    krassowski committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    39211ef View commit details
    Browse the repository at this point in the history