Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execution in console in terminal interaction mode #16348

Merged
merged 3 commits into from
May 22, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 21, 2024

References

Fixes #16339

Code changes

  • adds a test for executing console cells in terminal interaction mode (should fail in first commit)
  • fixes the issue

User-facing changes

Executing cells in console in terminal interaction mode works

Backwards-incompatible changes

None

@krassowski krassowski added the bug label May 21, 2024
@krassowski krassowski added this to the 4.2.x milestone May 21, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski changed the title Add an integration test for console in terminal mode Fix execution in console in terminal mode May 21, 2024
@krassowski krassowski changed the title Fix execution in console in terminal mode Fix execution in console in terminal interaction mode May 21, 2024
@krassowski krassowski marked this pull request as ready for review May 21, 2024 13:35
Copy link
Contributor

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code looks good. Thanks!

@krassowski krassowski merged commit f1a006d into jupyterlab:main May 22, 2024
81 of 82 checks passed
@krassowski
Copy link
Member Author

@meeseeksdev please backport to 4.2.x

Copy link

lumberbot-app bot commented May 22, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f1a006db4701ae545d5a2a05917b7e53b7074c94
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #16348: Fix execution in console in terminal interaction mode'
  1. Push to a named branch:
git push YOURFORK 4.2.x:auto-backport-of-pr-16348-on-4.2.x
  1. Create a PR against branch 4.2.x, I would have named this PR:

"Backport PR #16348 on branch 4.2.x (Fix execution in console in terminal interaction mode)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console not working with Interaction mode set to Terminal
2 participants