Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown preview for markdown files #2376

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

blink1073
Copy link
Contributor

Fixes #2371.

@blink1073
Copy link
Contributor Author

Let's hold of on merging this until #2157, since it is close to being finished and this will cause more merge conflicts.

@ellisonbg
Copy link
Contributor

ellisonbg commented Jun 6, 2017 via email

@blink1073
Copy link
Contributor Author

No longer blocked.

Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge after tests pass!

@blink1073 blink1073 merged commit 9282818 into jupyterlab:master Jun 6, 2017
@blink1073 blink1073 deleted the markdown-preview-option branch July 10, 2017 17:57
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement pkg:fileeditor pkg:markdownviewer status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command and context menu for prevewing markdown
2 participants