Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced settings UI, part 3 #2784

Merged
merged 37 commits into from Aug 16, 2017
Merged

Enhanced settings UI, part 3 #2784

merged 37 commits into from Aug 16, 2017

Conversation

afshin
Copy link
Member

@afshin afshin commented Aug 4, 2017 •
edited

Adds a two-column setting editor:

setting-editor

cc: @ellisonbg @cameronoelsen

@afshin afshin added this to the 1.0 milestone Aug 4, 2017
@afshin afshin self-assigned this Aug 4, 2017
@blink1073 blink1073 mentioned this pull request Aug 8, 2017
Closed
@afshin
Add methods to comment out defaults and their descriptions.
74b573b
@afshin
Update JSON with comments generation for schemas.
3ccfb9a
@afshin
Clean up.
ba88ec2
@afshin
Simplify indent/comment logic.
9a0da94
@afshin
Update JSON + comments generation logic.
0e76679
@afshin
Make sure plugin list overflows properly.
d05ad11
@afshin
Clean up (make tslint happy).
c297a0f
@afshin
Use StackedLayout, simplify CSS.
2e70387
@afshin
Switch to semantic editor names anticipating their new functionality.
f81bdc4
@afshin
Add isDirty to table editor.
5864d72
@afshin
Add switcher placeholder.
77d8403
@afshin
Handle switcher clicks.
7858443
@afshin
Fix event handling for switcher buttons to not change acitve shell wi…
acbd9a8 
…dget.
@afshin
Update switcher button styles.
c1b71e5
@afshin
Add initial commit of RawEditor.
d580d9f
@afshin
Add coreutils dependency.
940c279
@afshin
Move temporary SplitPanel to its own file.
e2db9fb
@afshin
Move plugin list to its own file.
c03f906
@afshin
Move plugin editor to its own file.
ff73a0a
@afshin
work in progress
c3ad71a
@afshin
Fix state changed signal and layout application.
b723419
@afshin
Null check on table editor.
19b8eb6
@afshin
Bugfix in plugin editor settings setter.
db56d13
@blink1073
Copy link
Member

Buttons need styling to account for dark mode:

@afshin
Copy link
Member Author

afshin commented Aug 15, 2017

Is this a bugfix in the dark theme or in the setting editor. I mentioned this issue to @cameronoelsen because I thought it would go in the theme.

@blink1073
Copy link
Member

I don't think the theme should influence a raw button node with no additional classes. I think we should use the CSS variables here.

@blink1073
Copy link
Member

Looks good, thanks!

@blink1073 blink1073 merged commit 9f5f0ac into jupyterlab:master Aug 16, 2017
@blink1073 blink1073 mentioned this pull request Aug 23, 2017
Closed
@afshin afshin deleted the settings-ui branch February 9, 2018 23:22
@jasongrout jasongrout modified the milestones: 1.0, 0.27 Feb 1, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@afshin afshin

Labels
enhancement pkg:settingeditor status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. status:Work in Progress tag:Settings
Projects
None yet
Milestone
0.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afshin @blink1073 @jasongrout