Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced settings UI, part 3 #2784

Merged
merged 37 commits into from Aug 16, 2017
Merged

Enhanced settings UI, part 3 #2784

merged 37 commits into from Aug 16, 2017

Conversation

@afshin
Copy link
Member

@afshin afshin commented Aug 4, 2017

Adds a two-column setting editor:

setting-editor

cc: @ellisonbg @cameronoelsen

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 15, 2017

Buttons need styling to account for dark mode:

@afshin
Copy link
Member Author

@afshin afshin commented Aug 15, 2017

Is this a bugfix in the dark theme or in the setting editor. I mentioned this issue to @cameronoelsen because I thought it would go in the theme.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 15, 2017

I don't think the theme should influence a raw button node with no additional classes. I think we should use the CSS variables here.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 16, 2017

Looks good, thanks!

@blink1073 blink1073 merged commit 9f5f0ac into jupyterlab:master Aug 16, 2017
2 checks passed
@afshin afshin deleted the settings-ui branch Feb 9, 2018
@jasongrout jasongrout removed this from the 1.0 milestone Feb 1, 2019
@jasongrout jasongrout added this to the 0.27 milestone Feb 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants