Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Save As shortcut #4560

Merged
merged 1 commit into from May 16, 2018
Merged

Added Save As shortcut #4560

merged 1 commit into from May 16, 2018

Conversation

@palewire
Copy link
Contributor

@palewire palewire commented May 12, 2018

Accel Shift S to keep it close to the existing save shortcut.

@jzf2101 jzf2101 self-requested a review May 15, 2018
@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented May 15, 2018

Thanks! Two things we are wondering about:

  1. What is the common shortcut for this?
  2. Does this conflict with any browser shortcuts.

We are open to this, but would like to get a sense of these. Assigned to @jzf2101 to help look at these things.

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented May 16, 2018

I looked at a several applications on my system (Ubuntu) and found this to be a pretty common keyboard shortcut. On Chrome this looks like it does not preempt any browser shortcut. On Firefox it looks like this overrides a shortcut for opening the debugger, but I don't view that as a serious problem, since that is a pretty specialized use-case, and there are many ways to open it.

I think we should move forwards with this. Thanks @palewire!

@ian-r-rose ian-r-rose merged commit 8a9aee1 into jupyterlab:master May 16, 2018
2 checks passed
@jasongrout jasongrout added this to the Beta 3 milestone Jun 12, 2018
@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@graidl
Copy link

@graidl graidl commented Aug 3, 2018

This shortcut as well as few others that are mentioned now as new in the changelog to jupyterlab version 0.33 have been removed in thenlater commit ee815a0. I wonder why. Either this feature also needs to be removed from the changelog, or the removal needs to be reverted.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants