Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only create the extension manager if it is needed, preventing unnecessary requests to npmjs.com #5075

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Only create the extension manager if it is needed, preventing unnecessary requests to npmjs.com #5075

merged 1 commit into from
Aug 9, 2018

Conversation

ian-r-rose
Copy link
Member

cc @afshin

@ian-r-rose ian-r-rose added this to the 0.34 milestone Aug 8, 2018
blink1073
blink1073 approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 79ec988 into jupyterlab:master Aug 9, 2018
@ian-r-rose ian-r-rose mentioned this pull request Aug 12, 2018
Closed
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
pkg:extensionmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
0.34
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-r-rose @blink1073