Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator precedence. #5175

Merged
merged 1 commit into from Aug 21, 2018

Conversation

ian-r-rose
Copy link
Member

Fixes jupyterlab/jupyterlab-google-drive#138.

Bug was introduced by yours-truly in #4757.

@blink1073
Copy link
Member

Error is legit:

$ tsc && node build.js
../notebook-extension/src/index.ts:509:24 - error TS2345: Argument of type 'string | number | true | ReadonlyJSONObject | ReadonlyJSONArray' is not assignable to parameter of type 'string'.
  Type 'number' is not assignable to type 'string'.
509       return createNew(cwd, kernelName);
                           ~~~

@ian-r-rose
Copy link
Member Author

Thanks, updated.

@blink1073
Copy link
Member

I'll release 0.34.1 after this

@jasongrout jasongrout merged commit 9560662 into jupyterlab:master Aug 21, 2018
@stonebig
Copy link

does it mean extensions like pyviz_comms must now point to 18.3 ?

https://github.com/pyviz/pyviz_comms/blob/master/package.json#L32.L35

@ian-r-rose
Copy link
Member Author

No, they should be fine, @stonebig

@stonebig
Copy link

ok.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create new notebook inside Drive tab
4 participants