codemirror: add config options to style selection

[futurist]

Fixes #5528

Below is a demo to use these options:

Screenshots

[blink1073]

cc @tgeorgeux for UX input.

[blink1073]

Thanks!

[futurist]

@tgeorgeux Can you review this PR? need any update please kindly let me know.

[tgeorgeux]

@futurist Sorry to take so long to get on this. First off, thank you for the issue/pull request being organized and easy to read/understand. That's very helpful, but I digress.

I like the styling here, I also think it makes sense to also bring those options into the advanced setting editor.

@blink1073 do you have thoughts? Given these add-ons have not been previously installed I think it makes sense to give people the option to turn them back off.

The relevant files that will need to be updated to include these in the advanced settings editor are:
jupyterlab/packages/codemirror-extension/schema/commands.json
jupyterlab/packages/codemirror-extension/src/index.ts

Otherwise looks great.

[blink1073]

Yeah I think making the highlighting configurable is fair.

[futurist]

@tgeorgeux I think the point is when user switching theme, the selection style should not mess up the theme style? If this is the case, I suggest the default value for these three options should be false, that case nothing changed except for after the user styling their selections, then manually turn on.

[futurist]

@tgeorgeux The latest commit set all these options false as default, please have a check.

[tgeorgeux]

@futurist I don't mind turning them on by default.

What I was addressing with my earlier comment is to add those options to the code mirror tab in the advanced settings editor. See the screenshot:

In order to add these options to the advanced settings editor, you will need to build out the relevant schema in these files:
jupyterlab/packages/codemirror-extension/schema/commands.json
jupyterlab/packages/codemirror-extension/src/index.ts

Also, CI stuff isn't my specialty but it looks like the appveyor build is breaking. @blink1073 are tests at 100 right now?

[blink1073]

Appveyor has been flaky...

[futurist]

@tgeorgeux I've pushed new commits, and think below really make sense:

[blink1073]

LGTM, thanks!

[tgeorgeux]

Thank you so much @futurist !