Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added shortcut for close-and-cleanup #5534

Merged
merged 2 commits into from Oct 27, 2018
Merged

added shortcut for close-and-cleanup #5534

merged 2 commits into from Oct 27, 2018

Conversation

@melsyt
Copy link
Contributor

@melsyt melsyt commented Oct 26, 2018

Fixes #4390

"properties": {
"command": { "default": "filemenu:close-and-cleanup" },
"keys": { "default": ["Ctrl Shift Q"] },
"selector": { "default": "body" },
Copy link
Member

@ian-r-rose ian-r-rose Oct 26, 2018

Thanks @melsyt! I wonder if we can be a bit narrower with the selector here. docmanager:close uses jp-Activity so that it only applies when you are focused on an activity in the main area (as opposed do something in the side panel or menu bar).

Copy link
Contributor Author

@melsyt melsyt Oct 26, 2018

Updated selector. Hope I understood you correctly!

@ian-r-rose
Copy link
Member

@ian-r-rose ian-r-rose commented Oct 26, 2018

Yes, this looks great, thanks @melsyt!

@afshin afshin merged commit f0dfbf6 into jupyterlab:master Oct 27, 2018
2 checks passed
@jasongrout jasongrout added this to the 1.0 milestone Feb 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants