added shortcut for close-and-cleanup #5534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-r-rose
reviewed
Oct 26, 2018
| "properties": { | ||
| "command": { "default": "filemenu:close-and-cleanup" }, | ||
| "keys": { "default": ["Ctrl Shift Q"] }, | ||
| "selector": { "default": "body" }, |
There was a problem hiding this comment.
Thanks @melsyt! I wonder if we can be a bit narrower with the selector here. docmanager:close uses jp-Activity so that it only applies when you are focused on an activity in the main area (as opposed do something in the side panel or menu bar).
There was a problem hiding this comment.
Updated selector. Hope I understood you correctly!
|
Yes, this looks great, thanks @melsyt! |
ian-r-rose
approved these changes
Oct 26, 2018
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4390