Improvements to dialog UX #5659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seawolf42 and @ellisonbg what is the current status of this feature? I start looking into #5241 for which persistent user choice will be needed. It will help and ensure consistency if I can build on this feature. Cheers |
|
@fcollonval I started work but got stuck. @ellisonbg asked me to go ahead and create the PR so somebody else could pick up where I left off and I haven't been tracking since that point. |
|
@seawolf42 thanks for the quick feedback. Could you grant me "collaborator" status on your Jupyterlab fork, so I can commit directly on the PR branch - avoiding starting a new one? |
|
@fcollonval done. |
|
Closing as stale, please feel free to reopen if you'd like to pick this back up |
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5617
This is the beginnings of a fix for this issue. I'll need help understanding exactly how to resolve this for the
console-extensiontool, and finalizing actually prompting the user to remember the selected result. As per direction from @ellisonbg creating the PR to determine what should happen next.Screenshots
If applicable, add before and after screenshots to help show the issue being fixed, or the appearance of a new feature.