-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transient_display_data message type and display such messages in console window #5699
Conversation
@jasongrout had a look at the code this morning and commented that
Jason suggested that
|
66df36e does the following:
Conceptually speaking, |
@BoPeng - #5711 illustrates the pattern we talked about today, of having a separate third-party extension that is listening to messages and inserting cells. In particular, https://github.com/jupyterlab/jupyterlab/blob/1197fdf358a401ecfa73b618b3963e5be35d3532/packages/console-extension/src/foreign.ts and https://github.com/jupyterlab/jupyterlab/blob/1197fdf358a401ecfa73b618b3963e5be35d3532/packages/console/src/foreign.ts are the relevant files. |
Still on the road, but thanks! |
@BoPeng and I discussed this today, and the conclusion was to (a) move the foreign message handling to a more self-contained plugin (done in #5711), and (b) move the transient message processing to a separate JupyterLab extension not in core so that it could iterate and experiment at a faster pace than core. Thanks again @BoPeng for all of your work pushing these things forward, and being patient while we came up with a way to do this! |
Re-implementation of PR #4879, reincarnation of proposal (#4550) on the display of
transient_display_data
(jupyter/jupyter_client#378).This PR basically provides a way to send
display_data
to be displayed in console windows, not in notebooks. Ittransient_display_data
, which is derived directly fromdisplay_data
with no additional field.ForeignHandler
of console totransient_display_data
just likedisplay_data
whenShow All Kernel Activity
is turned on.CodeCell
with hidden input and output prompt and display only thetransient_display_data
.What this means:
transient_display_data
message.display_data
for messages that are displayed in notebook (and associated console window ifShow All Kernel Activity
is enabled), andtransient_display_data
for messages that will only be displayed in the console windows.As stated in the
transient_display_data
PR, this message type can be used to send arbitrary information that should not be stored in the main notebook permanently. Obvious examples include additional debug messages and progress information.@afshin @jasongrout Let me know if this makes sense to you.
PS: I apologize for the use of an unofficial message type. However, I am in a chicken-egg situation where support from clients such as JLab is very important for the acceptance of the message type. I would love to see this PR accepted as an experimental feature that becomes official only after the message type is finalized.