Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Poll class, fix some tests, throttle polling. #6141

Merged
merged 142 commits into from Apr 9, 2019
Merged

Add Poll class, fix some tests, throttle polling. #6141

merged 142 commits into from Apr 9, 2019

Commits on Apr 8, 2019

  1. Remove line() function which is superfluous because of String.proto… 

    …type.repeat.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    1220ab5 View commit details
    Browse the repository at this point in the history

  2. Clean up doc strings in running extension.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    11c0d7d View commit details
    Browse the repository at this point in the history

  3. Update session manager to use async.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    77d61b0 View commit details
    Browse the repository at this point in the history

  4. Add Poll class to automatically poll and exponentially back off of fa… 

    …iling poll requests.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    b5919f6 View commit details
    Browse the repository at this point in the history

  5. Document polling and fix logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    0972f60 View commit details
    Browse the repository at this point in the history

  6. Update kernel manager to use poll class.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    4ce59a8 View commit details
    Browse the repository at this point in the history

  7. Improve warning when poll is rejected.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    ecb33c6 View commit details
    Browse the repository at this point in the history

  8. Update polling logic: check if disposed after poll promise resolves o… 

    …r rejects.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    55c9163 View commit details
    Browse the repository at this point in the history

  9. Add optional name to poll for console output.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    b554c1e View commit details
    Browse the repository at this point in the history

  10. Use poll class in terminal manager.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    89d6329 View commit details
    Browse the repository at this point in the history

  11. Update poll names.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    884c0ad View commit details
    Browse the repository at this point in the history

  12. Add support for when promise in poll instantiation.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    3621f2b View commit details
    Browse the repository at this point in the history

  13. Update terminal manager.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    4d225c8 View commit details
    Browse the repository at this point in the history

  14. Add when promise to session and kernel managers.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a012b4a View commit details
    Browse the repository at this point in the history

  15. Update shutdown logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    4ceaff4 View commit details
    Browse the repository at this point in the history

  16. Add support for poll interval variance.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    6dd0811 View commit details
    Browse the repository at this point in the history

  17. Log when poll reconnects. wobble => jitter

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    e982a8a View commit details
    Browse the repository at this point in the history

  18. Always send XSRF token if available. Fixes 403 bug after reconnects.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d30ac05 View commit details
    Browse the repository at this point in the history

  19. Support poll refreshing.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    e4768cd View commit details
    Browse the repository at this point in the history

  20. Update polling logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    b8cab09 View commit details
    Browse the repository at this point in the history

  21. Update poll logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    8867d02 View commit details
    Browse the repository at this point in the history

  22. Define Poll.Next type.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    576cd68 View commit details
    Browse the repository at this point in the history

  23. Update doc strings.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    008e89f View commit details
    Browse the repository at this point in the history

  24. Add support for max poll interval.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5b8651a View commit details
    Browse the repository at this point in the history

  25. Clean up poll class, make min/max public, change poll argument to `… 

    …factory`, etc.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    7c127e3 View commit details
    Browse the repository at this point in the history

  26. Add payload and disposed signals to the poll class.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    1d40e96 View commit details
    Browse the repository at this point in the history

  27. Change payload to resolved and add a rejected signal.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    03bb527 View commit details
    Browse the repository at this point in the history

  28. Add poll tick and ticked.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5ab8a5e View commit details
    Browse the repository at this point in the history

  29. Update poll chain logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    231f576 View commit details
    Browse the repository at this point in the history

  30. Emit signals only after the next poll promise is scheduled.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    1ce6bec View commit details
    Browse the repository at this point in the history

  31. Re-schedule poll execution if document is hidden.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d66e055 View commit details
    Browse the repository at this point in the history

  32. Clean up.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d0a827a View commit details
    Browse the repository at this point in the history

  33. Add schedule from standby state.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    c5dd256 View commit details
    Browse the repository at this point in the history

  34. Use poll refresh to trigger terminal manager refresh.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    7fd8b03 View commit details
    Browse the repository at this point in the history

  35. More clean up and async in services.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d40a63f View commit details
    Browse the repository at this point in the history

  36. Better document Poll#next.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    3184488 View commit details
    Browse the repository at this point in the history

  37. Remove _ready and _isReady and instead set _outstanding in the po… 

    …ll constructor.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    c925007 View commit details
    Browse the repository at this point in the history

  38. Clean up poll class.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    fb40f46 View commit details
    Browse the repository at this point in the history

  39. Since connected is always available, make it a public attribute inste… 

    …ad of only passing it into the promise factory.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    48d6747 View commit details
    Browse the repository at this point in the history

  40. Audit disposed flag after every asynchronous action. Catch promise re… 

    …jection in dispose method.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    79dc3fb View commit details
    Browse the repository at this point in the history

  41. Add initial poll test.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a380476 View commit details
    Browse the repository at this point in the history

  42. #next can always return a call to schedule and rely on that function … 

    …to return the outstanding promise.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9b43abb View commit details
    Browse the repository at this point in the history

  43. Change schedule to origin; it is clearer.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    7b5fe9d View commit details
    Browse the repository at this point in the history

  44. Update polling API, simplify signals. Reveal more state.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    8fb9dd3 View commit details
    Browse the repository at this point in the history

  45. More simplification and clean up of poll class.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    3753994 View commit details
    Browse the repository at this point in the history

  46. Synchronize poll state, ticks, and next promise resolutions.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5b32d95 View commit details
    Browse the repository at this point in the history

  47. Remove Poll.Next concept and simply resolve #next and #refresh() pr… 

    …omises to the poll instance itself. Allows returned promises to be self-contained for following the chain. Emit ticks after promise resolution.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9ec5351 View commit details
    Browse the repository at this point in the history

  48. Update poll documentation.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a8bb3a3 View commit details
    Browse the repository at this point in the history

  49. #refresh() should return a promise.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    efb14f6 View commit details
    Browse the repository at this point in the history

  50. Use variable name "poll" and "next" for PromiseDelegate instances coh… 

    …erently.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    925860d View commit details
    Browse the repository at this point in the history

  51. Use poll in status bar memory usage.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    582966c View commit details
    Browse the repository at this point in the history

  52. Simplify poll class.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    543f89a View commit details
    Browse the repository at this point in the history

  53. Simplify poll class, continued.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    76e4b5f View commit details
    Browse the repository at this point in the history

  54. Add poll start and stop methods.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d5ee4e3 View commit details
    Browse the repository at this point in the history

  55. Clean up poll dispose.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    6a437c1 View commit details
    Browse the repository at this point in the history

  56. Add documentation notes that indicate poll ticks as little as it can.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    b7065c5 View commit details
    Browse the repository at this point in the history

  57. Clean up poll API and handle waiting for when promise to resolve.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    0f01313 View commit details
    Browse the repository at this point in the history

  58. Add more poll tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    1480823 View commit details
    Browse the repository at this point in the history

  59. Update poll tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    1b0f40b View commit details
    Browse the repository at this point in the history

  60. Update when-resolved, when-rejected to instantiated-resolved, instant… 

    …iated-rejected.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    07c6fea View commit details
    Browse the repository at this point in the history

  61. Update poll tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    8ef1871 View commit details
    Browse the repository at this point in the history

  62. Fix poll stop behavior.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    7cc8152 View commit details
    Browse the repository at this point in the history

  63. Update poll tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a63e444 View commit details
    Browse the repository at this point in the history

  64. Handle case where an environment may have set document to null.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a249193 View commit details
    Browse the repository at this point in the history

  65. Handle situation where document is set to null by an environment.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    4f405f9 View commit details
    Browse the repository at this point in the history

  66. Parameterize standby of polls.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a6d1cda View commit details
    Browse the repository at this point in the history

  67. Update tests to use standby='never'.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d583b98 View commit details
    Browse the repository at this point in the history

  68. Fix shutdown signal emission logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    77eff05 View commit details
    Browse the repository at this point in the history

  69. After shutdown, entities ought to be disposed.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9508938 View commit details
    Browse the repository at this point in the history

  70. Make onActivateRequest test of code console synchronous.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5636cbf View commit details
    Browse the repository at this point in the history

  71. Use it.skip()

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    837ee7f View commit details
    Browse the repository at this point in the history

  72. Add Dialog.nuke (experimental)

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    c9373c2 View commit details
    Browse the repository at this point in the history

  73. Try Travis.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    308ea87 View commit details
    Browse the repository at this point in the history

  74. Rename to Dialog.flush().

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    029e41c View commit details
    Browse the repository at this point in the history

  75. Test acceptDialog (temp WIP)

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    bc984ef View commit details
    Browse the repository at this point in the history

  76. Add a tracker for all dialogs.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    956268f View commit details
    Browse the repository at this point in the history

  77. Partly re-enables dialog tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9819606 View commit details
    Browse the repository at this point in the history

  78. Re-enable all dialog tests except one that still fails.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    816f0df View commit details
    Browse the repository at this point in the history

  79. Add readonly functionality to polls.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a230954 View commit details
    Browse the repository at this point in the history

  80. Re-remove .travis.yml

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    40c4444 View commit details
    Browse the repository at this point in the history

  81. Remove artifacts from pre-InstanceTracker dialog tracking.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    066ccdc View commit details
    Browse the repository at this point in the history

  82. Make interval, jitter, min, and max (the polling frequency pa… 

    …rameters) editable.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    4c43ea7 View commit details
    Browse the repository at this point in the history

  83. Add readonly tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    f50dc72 View commit details
    Browse the repository at this point in the history

  84. Update jitter parameter to be a boolean | number and set its defaul… 

    …ts to 0 and 0.25 for false and true. Default to 0.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    88af585 View commit details
    Browse the repository at this point in the history

  85. Update jitter semantics.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    2f338d5 View commit details
    Browse the repository at this point in the history

  86. this._setup => this._frequency

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    f28f6de View commit details
    Browse the repository at this point in the history

  87. Clean up refresh/start/stop semantics and implementation.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9f8c0e1 View commit details
    Browse the repository at this point in the history

  88. Update docstrings.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    987fc3e View commit details
    Browse the repository at this point in the history

  89. Audit private variables and methods.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5e945ef View commit details
    Browse the repository at this point in the history

  90. Remove inaccurate docstrong.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d71336b View commit details
    Browse the repository at this point in the history

  91. Use standby when-hidden logic.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    618a1bf View commit details
    Browse the repository at this point in the history

  92. Update poll tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    36ab861 View commit details
    Browse the repository at this point in the history

  93. Check errors after normalizing in frequency function.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    25eb20a View commit details
    Browse the repository at this point in the history

  94. Update Poll#dispose() test.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    866f497 View commit details
    Browse the repository at this point in the history

  95. Respect readonly flag in refresh/start/stop.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5991335 View commit details
    Browse the repository at this point in the history

  96. Clean up.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    c73770a View commit details
    Browse the repository at this point in the history

  97. Fix client uses of Poll#refresh() to respect new semantics.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    2a56368 View commit details
    Browse the repository at this point in the history

  98. Fix refresh behavior and tests in services.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    c55b1e0 View commit details
    Browse the repository at this point in the history

  99. Add disposed phase.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9eeafb4 View commit details
    Browse the repository at this point in the history

  100. Check if disposed by checking current phase.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    07383d7 View commit details
    Browse the repository at this point in the history

  101. Handle tick failures in public methods.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    f03b410 View commit details
    Browse the repository at this point in the history

  102. Remove concept of readonly and use a separate IPoll interface model… 

    …ed on Signal/ISignal.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    8fa2de9 View commit details
    Browse the repository at this point in the history

  103. Fix dangling promises.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    6b7d95e View commit details
    Browse the repository at this point in the history

  104. Add generic parameter defaults for IPoll.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    366285f View commit details
    Browse the repository at this point in the history

  105. Simplify poll frequency API.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    f41d8f6 View commit details
    Browse the repository at this point in the history

  106. Update disposed handling and check for disposed status in override.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    20912a6 View commit details
    Browse the repository at this point in the history

  107. Define IPoll.Factory, make execute and schedule protected.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    3235137 View commit details
    Browse the repository at this point in the history

  108. Check that error exists before trying to print it in tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    f650bcc View commit details
    Browse the repository at this point in the history

  109. Clean up state initialization.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    63d5f3a View commit details
    Browse the repository at this point in the history

  110. Update docstrings.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d24d1f7 View commit details
    Browse the repository at this point in the history

  111. Update handling of frequency and standby.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5f7d216 View commit details
    Browse the repository at this point in the history

  112. IPoll.Standby => Poll.Standby

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    ba3b1b4 View commit details
    Browse the repository at this point in the history

  113. Use poll instead of setInterval CodeMirrEditor.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    d347a52 View commit details
    Browse the repository at this point in the history

  114. Update poll tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    e780d60 View commit details
    Browse the repository at this point in the history

  115. Clean up.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    11b9396 View commit details
    Browse the repository at this point in the history

  116. Polling should start as soon as when promise has resolved.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    2ad1e34 View commit details
    Browse the repository at this point in the history

  117. Poll#schedule() does not need to have the outstanding promise passed … 

    …into it.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5eaa49f View commit details
    Browse the repository at this point in the history

  118. Poll#_execute() does not need to have the outstanding promise passed … 

    …into it.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    ffe6b9f View commit details
    Browse the repository at this point in the history

  119. Add Poll#ready promise instead of checking manually in each method.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    528c5ad View commit details
    Browse the repository at this point in the history

  120. Fix disposed logic regression.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    731ff4b View commit details
    Browse the repository at this point in the history

  121. Update polling API, make ready protected. Update tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    be58ebc View commit details
    Browse the repository at this point in the history

  122. Refactor KernelManager and its tests to pass.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    8f4e7c6 View commit details
    Browse the repository at this point in the history

  123. Fix SessionManager and its tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    3e18400 View commit details
    Browse the repository at this point in the history

  124. Update TerminalManager.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    6e9bc50 View commit details
    Browse the repository at this point in the history

  125. Clean up.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    db18372 View commit details
    Browse the repository at this point in the history

  126. Update the jitter to return a uniformly random value between base +- … 

    …(base*jitter), capped by the min and max values.

The previous implementation would not be from a uniform distribution since it capped min/max after generating the random value.
    @jasongrout @afshin
    jasongrout authored and afshin committed Apr 8, 2019
    Copy the full SHA
    890bc2f View commit details
    Browse the repository at this point in the history

  127. Implement ‘decorrelated jitter’ as our backoff strategy. 

    See https://aws.amazon.com/blogs/architecture/exponential-backoff-and-jitter/
    @jasongrout @afshin
    jasongrout authored and afshin committed Apr 8, 2019
    Copy the full SHA
    c786303 View commit details
    Browse the repository at this point in the history

  128. Clean up and fix tests.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    790a540 View commit details
    Browse the repository at this point in the history

  129. Don't wait for pending promise to resolve before emitting ticked signal.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    acd5002 View commit details
    Browse the repository at this point in the history

  130. Address review suggestions.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    52dc3d0 View commit details
    Browse the repository at this point in the history

  131. Update documentation to be more clear to me.

    @jasongrout @afshin
    jasongrout authored and afshin committed Apr 8, 2019
    Copy the full SHA
    acfaa46 View commit details
    Browse the repository at this point in the history

  132. IPoll.Tick => IPoll.State

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    dabe07e View commit details
    Browse the repository at this point in the history

  133. Add test to verify tick promise resolves after every ticked signa… 

    …l and before the next `ticked` signal in lock-step.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    240876a View commit details
    Browse the repository at this point in the history

  134. Make Poll#tick test more robust.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    5df0d05 View commit details
    Browse the repository at this point in the history

  135. Clean up Poll#schedule() to make it easier to read and reason about.

    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    4bae4db View commit details
    Browse the repository at this point in the history

  136. Clean up some of the kernel manager async and request logic.

    @jasongrout
    jasongrout committed Apr 8, 2019
    Copy the full SHA
    520ba66 View commit details
    Browse the repository at this point in the history

  137. Make session manager class consistent with the kernel manager changes.

    @jasongrout
    jasongrout committed Apr 8, 2019
    Copy the full SHA
    28d55ba View commit details
    Browse the repository at this point in the history

  138. Merge pull request #24 from jasongrout/polling2 

    Clean up some of the kernel manager async and request logic.
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    9751173 View commit details
    Browse the repository at this point in the history

  139. Update terminal manager to be consistent with kernel/session manager … 

    …async logic.
    @jasongrout
    jasongrout committed Apr 8, 2019
    Copy the full SHA
    4f80f73 View commit details
    Browse the repository at this point in the history

  140. Merge pull request #25 from jasongrout/polling3 

    Update terminal manager to be consistent with kernel/session manager async logic
    @afshin
    afshin committed Apr 8, 2019
    Copy the full SHA
    a8f58a6 View commit details
    Browse the repository at this point in the history

  141. Revert session/terminal manager tests that now don’t change.

    @jasongrout
    jasongrout committed Apr 8, 2019
    Copy the full SHA
    2f203d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Update Poll#schedule docstring.

    @afshin
    afshin committed Apr 9, 2019
    Copy the full SHA
    b47481f View commit details
    Browse the repository at this point in the history