Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the CodeMirror-activeline-background and CodeMirror-gutter backgr… #6261

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

Tom-Nudell
Copy link

Set the CodeMirror-activeline-background and CodeMirror-gutter background-color to jp-layout-color
This resolves the CodeMirror ActiveLine highlight issue from issue #6053

This modifies the codemirror package

  • Look through open pull requests to see if someone has already started working on this.
  • Note what issue(s) this pull request addresses. (We strongly encourage the community to open an issue describing proposed work before opening a pull request.)
  • Provide a detailed description of the pull request. (Why are these changes necessary? How have they been implemented?)
  • For UI/UX changes, include before/after screenshots
  • Include a narrative description of visual or user interaction changes. How does your design effectively address the problem?
  • Provide a list of Jupyterlab packages the pull request modifies.
  • Describe any backwards incompatible changes to Jupyterlab’s public APIs.

Before

Before

After

After

…ound-color to jp-layout-color

This resolves the CodeMirror ActiveLine highlight issue from issue jupyterlab#6053
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

Great, thanks! Congrats on your first commit here!

@jasongrout jasongrout merged commit 0892fc5 into jupyterlab:master Apr 27, 2019
@jasongrout jasongrout added this to the 1.0 milestone Apr 27, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants