Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tab bar icon background size so SVGs of other sizes may be used. #6306

Merged
merged 1 commit into from May 4, 2019

Conversation

ian-r-rose
Copy link
Member

Fixes #5718

References

#5718

Code changes

Just some CSS

User-facing changes

SVGs of various sizes can now be used as icons in tab bars.

Before:
image

After:
image

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

Thanks!

@blink1073 blink1073 merged commit 8c72b12 into jupyterlab:master May 4, 2019
@bollwyvl
Copy link
Contributor

bollwyvl commented May 5, 2019

Awesome!

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG images are not scaled in tab headings
4 participants