Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh yarn.lock. #6388

Merged
merged 4 commits into from May 23, 2019
Merged

Refresh yarn.lock. #6388

merged 4 commits into from May 23, 2019

Conversation

jasongrout
Copy link
Contributor

I deleted the yarn.lock and did a jlpm install to refresh the packages contained in it.

I deleted the yarn.lock and did a `jlpm install` to refresh the packages contained in it.
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 1.0 milestone May 22, 2019
@blink1073
Copy link
Member

LGTM, thanks!

@blink1073 blink1073 merged commit ce4c47a into jupyterlab:master May 23, 2019
@vidartf
Copy link
Member

vidartf commented May 23, 2019

Has this gotten / should this get a pass through yarn-deduplicate -s fewer to help reduce deduping and consequently final bundle size?

@jasongrout
Copy link
Contributor Author

I did not run it through yarn-deduplicate.

@jasongrout
Copy link
Contributor Author

I did a test running yarn-deduplicate -s fewer and then comparing jlpm run build:dev:prod. The end result was that this PR (i.e., current master) generates pretty much identically-sized static js files, with one exception where current master (this PR) is 5K less than using yarn-deduplicate -s fewer.

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
@jasongrout jasongrout deleted the yarn-refresh branch August 20, 2020 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants