Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed sphinx warning for deprecated source_parsers config field #6807

Merged

Conversation

telamonian
Copy link
Member

References

Code changes

Minor fix for a Sphinx warning that comes up during the docs CI test.

While trying to figure why a docs CI test failed (it was github flood protection during the link check), I noticed this warning:

/opt/hostedtoolcache/Python/3.6.8/x64/lib/python3.6/site-packages/sphinx/util/compat.py:33: RemovedInSphinx30Warning: The config variable "source_parsers" is deprecated. Please update your extension for the parser and remove the setting.
  RemovedInSphinx30Warning)
/opt/hostedtoolcache/Python/3.6.8/x64/lib/python3.6/site-packages/sphinx/util/compat.py:37: RemovedInSphinx30Warning: app.add_source_parser() does not support suffix argument. Use app.add_source_suffix() instead.
  app.add_source_parser(suffix, parser)

I fixed the issue following the markdown setup instructions at https://www.sphinx-doc.org/en/master/usage/markdown.html

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ian-r-rose
Copy link
Member

Looks good to me, thanks @telamonian

@ian-r-rose ian-r-rose merged commit 2083f7b into jupyterlab:master Jul 12, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
@blink1073 blink1073 added this to the 1.1 milestone Aug 22, 2019
@jasongrout jasongrout modified the milestones: 1.1, 1.0.x, 1.0.3 Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants